Add SvelteKit web framework support #5525
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5525 +/- ##
==========================================
- Coverage 55.97% 55.92% -0.06%
==========================================
Files 321 322 +1
Lines 21663 21706 +43
Branches 4419 4427 +8
==========================================
+ Hits 12125 12138 +13
- Misses 8472 8502 +30
Partials 1066 1066
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
LGTM, @austincrim to test against his sample & we'll add the changelog. Merge after this CLI release is cut.
|
Hi @austincrim , great job 👍 |
|
Hey, @simpros, thanks for checking it out! Can you try |
|
|
|
Oh sorry, I meant that I've used I am using @sveltejs/adapter-node and the Maybe a sample svelte.config.js file would help? 🙂 |
|
@simpros I would try leaving the adapter as import adapter from '@sveltejs/adapter-auto';
/** @type {import('@sveltejs/kit').Config} */
const config = {
kit: {
// adapter-auto only supports some environments, see https://kit.svelte.dev/docs/adapter-auto for a list.
// If your environment is not supported or you settled on a specific environment, switch out the adapter.
// See https://kit.svelte.dev/docs/adapters for more information about adapters.
adapter: adapter()
}
};
export default config;@ideodora |
|
@austincrim sorry to bother you again. The adapter-auto seems to work, my application gets deployed but the cloud function is erroring with this message Did I miss to update an dependency? 🤔 |
|
@austincrim I think firebase-tools/src/frameworks/index.ts Line 237 in b80de64 It seems to use 'npm bin` which removed since npm v.9 Would you mind to tell me your working environments? mine: UPDATE: related: |
Co-authored-by: James Daniels <jamesdaniels@google.com>
|
I'm seeing this. Have tried node@16 and node@18, and npm@8 and npm@9. Both |
Description
In conjunction with FirebaseExtended/firebase-framework-tools#56, this PR adds SvelteKit support to Firebase web frameworks.
A temp change was made inframeworks/index.tsto support ESM, but another PR (#5540) is open that should fix this.FIREBASE_FRAMEWORKS_VERSIONto new minor versionScenarios Tested
Tested with the SvelteKit demo app, including static site generation, server-side rendering, and API routes.