Fix regex page matcher for Next.js middlewares version 1 #5496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
requested changes
Feb 10, 2023
|
Are there any other Next 12 gotchas? E.g, rewrites/redirects/headers? |
I can check but I don't think so. Middlewares was still in beta before Next.js 12.2 so that was the main thing we're dealing with that has changed |
|
Add changelog |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5496 +/- ##
==========================================
+ Coverage 55.20% 55.23% +0.02%
==========================================
Files 328 328
Lines 22410 22415 +5
Branches 4573 4574 +1
==========================================
+ Hits 12372 12381 +9
+ Misses 8936 8932 -4
Partials 1102 1102
☔ View full report in Codecov by Sentry. |
TheIronDev
reviewed
Mar 10, 2023
TheIronDev
previously requested changes
Mar 10, 2023
leoortizz
requested review from
TheIronDev and
jamesdaniels
and removed request for
jamesdaniels
jamesdaniels
approved these changes
Mar 20, 2023
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
* fix regex matcher for middleware version 1 * MiddlewareManifest type * changelog * get middleware matcher regexes as util + unit tests * prettier in changelog
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
* fix regex matcher for middleware version 1 * MiddlewareManifest type * changelog * get middleware matcher regexes as util + unit tests * prettier in changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Projects using the first version of the Next.js middleware were failing to deploy due to a difference in
middleware-manifest.json. The first version was in Next.js until v12.1.6. Version 2 was introduced in Next.js 12.2.0. This PR handles the middleware page matchers for version 1.Scenarios Tested
Sample Commands