Convert e2e unit tests to use Jest #8666
Merged
+2,090
−2,103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2E tests have been broken since upgrading TypeScript from 4 to 5. The reason is that between TypeScript 5.2.2 and TypeScript 5.3.3, an internal property on sourceFiles,
resolvedModules
was removed, and moved toProgram
. See PR: microsoft/TypeScript#55790 This causedkarma-typescript
, which we use for the karma tests, to break as it was depending on that field to find modules and determine if it should bundle files.karma-typescript
is deprecated and no longer maintained so we can't get a fix from it even though we know the problem.In light of this, I'm migrating our E2E tests from karma to Jest.
Pros:
Cons:
Details
useFetchStreams
on Firestore tests as JSDOM does not handle fetch readable streams well. There's no public API to turn it off in compat so I had to do it pretty hacky.