Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable all webdriver redirect tests #7801

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Disable all webdriver redirect tests #7801

merged 1 commit into from
Nov 22, 2023

Conversation

NhienLam
Copy link
Contributor

Discussion

  • Webdriver redirect tests started to fail on CI.
  • This PR disables the failing tests to unblock other PRs.
  • We will investigate, fix, and enable the tests again.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2023

⚠️ No Changeset found

Latest commit: 321a7be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (00235ba) and merge commit (93d1e18).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8GCNkUxQnz.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (00235ba) and merge commit (93d1e18).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GK3IlhYNnl.html

@renkelvin renkelvin merged commit a5c1a35 into master Nov 22, 2023
41 checks passed
@renkelvin renkelvin deleted the webdriver branch November 22, 2023 18:53
renkelvin pushed a commit that referenced this pull request Nov 27, 2023
Revert "Disable all webdriver redirect tests (#7801)"
6a38841 
This reverts commit a5c1a35.
renkelvin pushed a commit that referenced this pull request Dec 1, 2023
Revert "Disable all webdriver redirect tests (#7801)"
d69313e
renkelvin pushed a commit that referenced this pull request Dec 1, 2023
Revert "Revert "Disable all webdriver redirect tests (#7801)""
7196475 
This reverts commit d69313e.
renkelvin pushed a commit that referenced this pull request Dec 1, 2023
Revert "Disable all webdriver redirect tests (#7801)"
904c75a
renkelvin pushed a commit that referenced this pull request Dec 1, 2023
Revert "Revert "Disable all webdriver redirect tests (#7801)""
339ed43 
This reverts commit d69313e.
renkelvin pushed a commit that referenced this pull request Dec 1, 2023
Revert "Disable all webdriver redirect tests (#7801)"
0276d78 
Revert "Revert "Disable all webdriver redirect tests (#7801)""

This reverts commit d69313e.

Revert "Revert "Revert "Disable all webdriver redirect tests (#7801)"""

This reverts commit 339ed43.
@firebase firebase locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@prameshj prameshj Awaiting requested review from prameshj

@renkelvin renkelvin Awaiting requested review from renkelvin

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NhienLam @google-oss-bot @DellaBitta @renkelvin