Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid changeset check on PRs to non-master branches #7110

Merged
merged 2 commits into from Mar 10, 2023
Merged

Avoid changeset check on PRs to non-master branches #7110

merged 2 commits into from Mar 10, 2023

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Mar 9, 2023

PRs to feature branches (and release branch) don't need changeset checker run. Should only run the changeset check on PRs targeting master.

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023

⚠️ No Changeset found

Latest commit: b154c53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review March 9, 2023 17:46
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (2e22d5b) and merge commit (312cadd).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8KMuZB1l5z.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (2e22d5b) and merge commit (312cadd).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HVFM8Cra2z.html

dwyfrequency
dwyfrequency approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dconeybe added a commit that referenced this pull request Mar 9, 2023
@dconeybe
disable the annoying 'check changeset' check, which is broken when ta…
daf049c 
…rgeting non-master branches.

This is a cherry-pick of #7110
@dconeybe dconeybe mentioned this pull request Mar 9, 2023
Merged
@hsubox76 hsubox76 merged commit c4276bd into master Mar 10, 2023
@hsubox76 hsubox76 deleted the ch-ccfix3 branch March 10, 2023 16:59
renkelvin pushed a commit that referenced this pull request Mar 21, 2023
@hsubox76
Avoid changeset check on PRs to non-master branches (#7110)
19259b8
@firebase firebase locked and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@dconeybe dconeybe dconeybe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hsubox76 @google-oss-bot @dwyfrequency @dconeybe