Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface the error for COUNT queries #7072

Merged
merged 3 commits into from Mar 6, 2023
Merged

Surface the error for COUNT queries #7072

merged 3 commits into from Mar 6, 2023

Conversation

qtz1
Copy link
Contributor

@qtz1 qtz1 commented Mar 1, 2023 •
edited by hsubox76

This is necessary for errors where an index needs to be created and the user needs the creation link

@qtz1
Surface the error for COUNT queries
49a669c 
This is necessary for errors where an index needs to be created and the user needs the creation link
@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2023 •
edited

⚠️ No Changeset found

Latest commit: 5438a0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@qtz1 qtz1 marked this pull request as draft March 1, 2023 18:54
@qtz1 qtz1 marked this pull request as ready for review March 1, 2023 18:59
@qtz1 qtz1 marked this pull request as draft March 6, 2023 20:41
@qtz1 qtz1 marked this pull request as ready for review March 6, 2023 21:40
@qtz1 qtz1 merged commit 547348b into firebase:master Mar 6, 2023
@qtz1 qtz1 deleted the patch-1 branch March 6, 2023 21:41
renkelvin pushed a commit that referenced this pull request Mar 21, 2023
@qtz1
Surface the error for COUNT queries (#7072)
9b84fe7 
* Surface the error for COUNT queries

This is necessary for errors where an index needs to be created and the user needs the creation link

* Update index.console.ts

* fix formatting
renkelvin pushed a commit that referenced this pull request Mar 21, 2023
@qtz1
Surface the error for COUNT queries (#7072)
9d84a2e 
* Surface the error for COUNT queries

This is necessary for errors where an index needs to be created and the user needs the creation link

* Update index.console.ts

* fix formatting
@firebase firebase locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@qtz1 qtz1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qtz1 @ehsannas