-
Notifications
You must be signed in to change notification settings - Fork 923
Add documentation for ActionCodeURL #3933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@@ -4,6 +4,8 @@ | |||
|
|||
## ActionCodeURL.operation property | |||
|
|||
The action performed by the email action link. It returns from one of the types from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the @link got truncated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah that answers it
@@ -4,6 +4,8 @@ | |||
|
|||
## ActionCodeURL.operation property | |||
|
|||
The action performed by the email action link. It returns from one of the types from [ActionCodeInfo](./auth-types.actioncodeinfo.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does {@link ActionCodeInfo}
work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it works in the auth-types docs but not the auth docs, probably will self resolve once I add documentation for ActionCodeInfo in both
@@ -45,11 +49,20 @@ const MODE_TO_OPERATION_MAP: { [key: string]: externs.Operation } = { | |||
|
|||
/** | |||
* Maps the mode string in action code URL to Action Code Info operation. | |||
* | |||
* @param mode | |||
* @internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to do this right? Since these are not exported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right, doing it for consistency here anyway, no promises I'll do it everywhere
Binary Size ReportAffected SDKsNo changes between base commit (d4966cf) and head commit (458bd6e). Test Logs
|
Size Analysis ReportAffected ProductsNo changes between base commit (d4966cf) and head commit (458bd6e). Test Logs
|
No description provided.