Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: firebase/firebase-functions
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.9.0
Choose a base ref
...
head repository: firebase/firebase-functions
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.9.1
Choose a head ref
  • 5 commits
  • 4 files changed
  • 3 contributors

Commits on Jul 31, 2020

  1. Copy the full SHA
    02f61cf View commit details

Commits on Aug 7, 2020

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c69c974 View commit details

Commits on Aug 10, 2020

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    d1432c5 View commit details

Commits on Aug 12, 2020

  1. 1

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    84433df View commit details
  2. 3.9.1

    google-oss-bot committed Aug 12, 2020
    Copy the full SHA
    ae9e856 View commit details
Showing with 20 additions and 21 deletions.
  1. +2 −3 CHANGELOG.md
  2. +2 −2 package.json
  3. +15 −15 src/cloud-functions.ts
  4. +1 −1 src/providers/https.ts
5 changes: 2 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
- Updates HTTP callable functions to use structured logging for Node 10+ environments.
- Adds type hints for new Cloud Functions regions `asia-northeast3`, `asia-south1`, and `asia-southeast2`.
- Updates type definition of `https.onRequest` to allow for promises (async functions).
- Updates `firebase-admin` dependency to support `^9.0.0` in addition to `^8.0.0`. Note that `firebase-admin` no longer supports Node.js 8.x as of `9.0.0`.
- Fixes logging of unexpected errors in `https.onCall()` functions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "firebase-functions",
"version": "3.9.0",
"version": "3.9.1",
"description": "Firebase SDK for Cloud Functions",
"keywords": [
"firebase",
@@ -78,7 +78,7 @@
"yargs": "^15.3.1"
},
"peerDependencies": {
"firebase-admin": "^8.0.0"
"firebase-admin": "^8.0.0 || ^9.0.0"
},
"engines": {
"node": "^8.13.0 || >=10.10.0"
30 changes: 15 additions & 15 deletions src/cloud-functions.ts
Original file line number Diff line number Diff line change
@@ -89,22 +89,22 @@ export interface EventContext {
eventId: string;

/**
* Type of event. Valid values are:
* Type of event. Possible values are:
*
* * `providers/google.firebase.analytics/eventTypes/event.log`
* * `providers/firebase.auth/eventTypes/user.create`
* * `providers/firebase.auth/eventTypes/user.delete`
* * `providers/firebase.crashlytics/eventTypes/issue.new`
* * `providers/firebase.crashlytics/eventTypes/issue.regressed`
* * `providers/firebase.crashlytics/eventTypes/issue.velocityAlert`
* * `providers/google.firebase.database/eventTypes/ref.write`
* * `providers/google.firebase.database/eventTypes/ref.create`
* * `providers/google.firebase.database/eventTypes/ref.update`
* * `providers/google.firebase.database/eventTypes/ref.delete`
* * `providers/cloud.firestore/eventTypes/document.write`
* * `providers/cloud.firestore/eventTypes/document.create`
* * `providers/cloud.firestore/eventTypes/document.update`
* * `providers/cloud.firestore/eventTypes/document.delete`
* * `google.analytics.event.log`
* * `google.firebase.auth.user.create`
* * `google.firebase.auth.user.delete`
* * `google.firebase.crashlytics.issue.new`
* * `google.firebase.crashlytics.issue.regressed`
* * `google.firebase.crashlytics.issue.velocityAlert`
* * `google.firebase.database.ref.write`
* * `google.firebase.database.ref.create`
* * `google.firebase.database.ref.update`
* * `google.firebase.database.ref.delete`
* * `google.firestore.document.write`
* * `google.firestore.document.create`
* * `google.firestore.document.update`
* * `google.firestore.document.delete`
* * `google.pubsub.topic.publish`
* * `google.firebase.remoteconfig.update`
* * `google.storage.object.finalize`
2 changes: 1 addition & 1 deletion src/providers/https.ts
Original file line number Diff line number Diff line change
@@ -469,7 +469,7 @@ export function _onCallWithOptions(
} catch (err) {
if (!(err instanceof HttpsError)) {
// This doesn't count as an 'explicit' error.
error('Unhandled error', error);
error('Unhandled error', err);
err = new HttpsError('internal', 'INTERNAL');
}