Update firebase-functions version to include updated types
#139
+8
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the version of `firebase-functions` to be the version of `firebase-functions` that includes the updated `@type` definitions.
TheIronDev
force-pushed
the
tystark.type-fixes-continued
branch
from
accbd5b to
778eb8c
Compare
inlined
reviewed
May 10, 2022
| @@ -21,7 +21,7 @@ export const alertsAppDistributionOnNewTesterIosDevicePublished: MockCloudEventP | |||
| createTime: now, | |||
| endTime: now, | |||
| payload: { | |||
| '@type': | |||
| ['@type']: | |||
There was a problem hiding this comment.
FYI: the brackets here read a little funny. You only need the brackets if you need to evaluate the value in the brackets to get a real key name. E.g.
const keyName = '@type';
payload = {
[keyName]: 'type.googleapis.com/...'
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the version of
firebase-functionsto be the version offirebase-functionsthat includes the updated@typedefinitions.The parent branch (
inlined.type-fixes) has already made the necessary type changes.Without this, the type definitions may have a mismatch between whats defined in 3.20.* and 3.21.*.