Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix for issue #2320 #2321

Merged
merged 1 commit into from Oct 3, 2023
Merged

Bug Fix for issue #2320 #2321

merged 1 commit into from Oct 3, 2023

Conversation

rishabhAjay
Copy link
Contributor

@rishabhAjay rishabhAjay commented Sep 30, 2023 •
edited

fixes #2320

@google-cla
Copy link

google-cla bot commented Sep 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lahirumaramba lahirumaramba self-requested a review October 3, 2023 18:25
@lahirumaramba lahirumaramba self-assigned this Oct 3, 2023
@lahirumaramba lahirumaramba mentioned this pull request Oct 3, 2023
Closed
@lahirumaramba
Copy link
Member

Thank you for the fix!

@lahirumaramba lahirumaramba merged commit 1661adc into firebase:master Oct 3, 2023
5 checks passed
pragatimodi pushed a commit that referenced this pull request Oct 18, 2023
@rishabhAjay @pragatimodi
Bug Fix for issue #2320 (#2321)
a2c2431
pragatimodi added a commit that referenced this pull request Oct 18, 2023
@pragatimodi
undo package json changes
9d69dd8 
passkey config admin changes

Bug Fix for issue #2320 (#2321)

fixed unit test errors

lint fixes + integration

remove integration tests

adding comments

undo package json changes

undo package json changes
@roblo1801 roblo1801 mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'match')
2 participants
@rishabhAjay @lahirumaramba