Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Add Email Privacy support in Project and Tenant config #2198

Merged
merged 16 commits into from Sep 7, 2023
Merged

feat(auth): Add Email Privacy support in Project and Tenant config #2198

merged 16 commits into from Sep 7, 2023

Conversation

pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented May 28, 2023 •
edited by lahirumaramba

RELEASE NOTE: Added email privacy support in project and tenant configuration

@pragatimodi pragatimodi marked this pull request as ready for review June 5, 2023 16:35
Xiaoshouzi-gh
Xiaoshouzi-gh requested changes Jun 6, 2023
View reviewed changes
src/auth/tenant.ts Outdated Show resolved Hide resolved
test/integration/auth.spec.ts Show resolved Hide resolved
test/integration/auth.spec.ts Show resolved Hide resolved
kevinthecheung
kevinthecheung approved these changes Jun 7, 2023
View reviewed changes
src/auth/auth-config.ts Outdated Show resolved Hide resolved
src/auth/auth-config.ts Outdated Show resolved Hide resolved
@pragatimodi @kevinthecheung
Apply suggestions from code review
d885be7 
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
@lahirumaramba lahirumaramba added release:stage Stage a release candidate release-note labels Aug 18, 2023
lahirumaramba
lahirumaramba approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please get the docs reviewed by a TW before merging
Just noticed Kevin's reviews. Thanks

@pragatimodi
Copy link
Contributor Author

Hey @lahirumaramba, looks like the remoteConfig integration tests are failing. But they aren't related to this change, should we go ahead and merge this PR then?

@pragatimodi pragatimodi merged commit a4019e4 into master Sep 7, 2023
7 checks passed
@lahirumaramba lahirumaramba deleted the email-privacy branch September 26, 2023 20:05
@roblo1801 roblo1801 mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@renkelvin renkelvin renkelvin approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

Assignees
No one assigned
Labels
release:stage Stage a release candidate release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pragatimodi @lahirumaramba @renkelvin @kevinthecheung @Xiaoshouzi-gh