Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Disable run as user for AHK files #15428

Merged
merged 3 commits into from
May 20, 2024
Merged

Code Quality: Disable run as user for AHK files #15428

merged 3 commits into from
May 20, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 19, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsExecutableFile is also used in places other than run as user, such as pin to Start menu. So it would be better to include AHK files in executable files, and only disable run as user in case of AHK files.

yaira2 and others added 2 commits May 20, 2024 07:17
Co-authored-by: 0x5bfa <62196528+0x5bfa@users.noreply.github.com>
@yaira2 yaira2 requested a review from hishitetsu May 20, 2024 14:20
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 20, 2024
@yaira2 yaira2 merged commit 2cf4dc8 into main May 20, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/FixAhk branch May 20, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Run as another user is not possible for AHK files
3 participants