Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added an action to edit "Batch" files in Notepad #15429

Merged
merged 4 commits into from
May 20, 2024
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 19, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Selected a batch file and confirmed the "Edit in Notepad" button was displayed in the toolbar
  2. Confirmed the button only displays for batch files
  3. Confirmed the action works as expected

Screenshots
image

@yaira2 yaira2 changed the title Feature: Added an action to open batch files in Notepad Feature: Added an action to edit "Batch" files in Notepad May 19, 2024
@XTorLukas
Copy link
Contributor

How about adding an option to choose the main editor program, for example I use VSCode instead of Notepad?

@yaira2
Copy link
Member Author

yaira2 commented May 19, 2024

That will be possible when custom args are added to actions.

@yaira2 yaira2 requested a review from 0x5bfa May 20, 2024 14:42
@yaira2
Copy link
Member Author

yaira2 commented May 20, 2024

I'll also add this to the docs

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code wise.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 20, 2024
@yaira2 yaira2 merged commit a8a246d into main May 20, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/OpenInNotepad branch May 20, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add "Edit" action for opening Batch files in Notepad
3 participants