Lotus Miner & Node v1.28.2 Release

[rjan90]

Lotus Miner and Node v1.28.2 Release

😶‍🌫 Meta

• Scope: Miner & Node
• Is this linked with a network upgrade, and thus mandatory? No
• Related network upgrade version: n/a

🚢 Estimated shipping date

Candidate	Date	Release URL
Stable (non-RC)	Week of 2024-08-12	https://github.com/filecoin-project/lotus/releases/tag/v1.28.2

🪢 Dependencies for releases

Note

1. This is the set of changes that need to make it in for a given RC. This is effectively the set of changes to cherry-pick from master.
2. They can be checked as done once they land in master.
3. They are presented here for quick reference, but backporting is tracked in each Release Checklist.

Stable (non-RC)

• fix: miner: Fix DDO pledge math #12341
•  chore: backport pledge fixes to 1.28.2-prep branch #12395

✅ Release Patch Checklist

Before Release

• Open PR against RELEASE_ISSUE_TEMPLATE.md for capturing updates: docs(release): v1.28.2 and v1.29.0 release template improvements #12378
• Fork a new branch (release/v1.28.2) from release/v1.28.2 and make any further release-related changes to this branch.
• master branch Version string updates
  • bump the version(s) in build/version.go to vX.Y.Z+1-dev.
    • Ensure to update the appropriate version string based on whether you are creating a node release (NodeBuildVersion), a miner release (MinerBuildVersion), or both.
  • Run make gen && make docsgen-cli before committing changes.
  • Create a PR with title build(vX.Y.Z+1): set initial version string
    • Link to PR: chore: bump MinerBuildVersion in master to v1.28.3-dev #12380
  • Merge PR

Stable Release PR

• Update the version string(s) in build/version.go to one NOT ending with '-rcX'.
  • Ensure to update the appropriate version string based on whether you are creating a node release (NodeBuildVersion), a miner release (MinerBuildVersion), or both.
• Run make gen && make docsgen-cli to generate documentation
• Changelog prep
  • Editorial review (e.g., callout breaking changes, new features, FIPs, actor bundles)
  • (network upgrade) Specify whether the Calibration or Mainnet upgrade epoch has been specified or not yet.
    • Example where these weren't specified yet: PR #12169
  • Ensure no missing content when spot checking git history
    • Example command looking at git commits: git log --oneline --graph vA.B.C.., where A.B.C correspond to the previous release.
    • Example GitHub UI search looking at merged PRs into master: https://github.com/filecoin-project/lotus/pulls?q=is%3Apr+base%3Amaster+merged%3A%3EYYYY-MM-DD
    • Example gh cli command looking at merged PRs into master and sorted by title to group similar areas: `gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, mergedAt, .author.login, .title] | @TSV' | sort -k4
• Create a PR with title build(vX.Y.Z): release vX.Y.Z
  • Link to PR: build: release: v1.28.2 #12392
  • Opening a PR will trigger a CI run that will build assets, and attach the assets.
• Merge the PR
  • Opening the PR will trigger a CI run that will build assets, attach the assets to the GitHub release, publish the GitHub release, and create the corresponding git tag.
• Publish the release:
  • “Draft a new release” in GH
  • Choose the release/v1.28.2 branch, for the tag, set it to v1.28.2 - and create title + description.
• Add the second tag via git cmd´s
  • git checkout v1.28.2
  • git tag miner/v1.28.2
  • git push origin miner/v1.28.2
• Update 🚢 Estimated shipping date table
• Comment on this issue announcing the release
  • Link to issue comment:

Testing

Note

Link to any special steps for testing releases beyond ensuring CI is green. Steps can be inlined here or tracked elsewhere.

Post-Release

• Open a pull request against master with a merge of the release/vX.Y.Z branch.
  • Conflict resolution should ignore the changes to version.go (keep the -dev version from master).
  • Link to PR: chore: post release steps for #12379 (v1.28.2 miner and node patch release) #12400
• Finish updating/merging the RELEASE_ISSUE_TEMPLATE.md PR from Before RC1 with any improvements determined from this latest release iteration.

❤️ Contributors

See the final release notes!

⁉️ Do you have questions?

Leave a comment in this ticket!

[rjan90]

Scribbling down some notes while I go through this process and then we can consider. Keep in mind that this is a patch-release, and therefor a little outside the normal release flow:

• Fork a new branch (release/vX.Y.Z or release/miner/vX.Y.Z) from master and make any further release-related changes to this branch.

This is only relevant in the case when shipping a normal release (i.e not a patch release). For patch releases this would be:

• Fork a new branch (release/vX.Y.Z or release/miner/vX.Y.Z) from the last stable release/vX.Y.Z or release/miner/vX.Y.Z and make any further release-related changes to this branch.

[rjan90]

Open PR against RELEASE_ISSUE_TEMPLATE.md with title docs(vX.Y.Z): release template improvements for improving future releases.

This is kind of in a weird spot, since we are asking for opening a PR - but unless you have any immediate changes to the RELEASE_ISSUE_TEMPLATE.md file you can´t open a PR.

[BigLep]

@rjan90 : not in the critical path of the release itself, but FYI concerning template improvements:

1. I expanded docs(release): v1.28.2 and v1.29.0 release template improvements #12378 to include 1.28.2 and 1.29.0
2. Concerning differentiating minor vs patch release steps, I created a3747f5
3. Concerning opening the RELEASE_ISSUE_TEMPLATE.md improvements early, I added some text with 1692ece

[jennijuju]

https://github.com/filecoin-project/lotus/releases/tag/v1.28.2 is a thing

[rjan90]

Finish updating/merging the RELEASE_ISSUE_TEMPLATE.md PR from Before RC1 with any improvements determined from this latest release iteration.

Feedback has been incorporated as part of #12378. Closing this release ticket now.