Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(knex): Add sqlite to returning clients #3389

Merged
merged 1 commit into from Jan 20, 2024
Merged

Conversation

Muliro1
Copy link
Contributor

@Muliro1 Muliro1 commented Jan 19, 2024

Summary

(If you have not already please refer to the contributing guideline as described
here
)

  • Tell us about the problem your pull request is solving.
  • Are there any open issues that are related to this?
  • Is this PR dependent on PRs in other repos?

If so, please mention them to keep the conversations linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.

If this is a new feature, please remember to add the appropriate documentation in their respective pages in the docs folder.

Thanks for contributing to Feathers! ❤️

Closes #3388

@daffl daffl changed the title sql fix(knex): Add sqlite to returning clients Jan 20, 2024
@daffl daffl merged commit 59fb40b into feathersjs:dove Jan 20, 2024
2 checks passed
@daffl
Copy link
Member

daffl commented Jan 20, 2024

Thank you, this will go out with the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'sqlite3' to the RETURNING_CLIENTS constant in KnexAdapter
2 participants