Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(memory): Ensure correct pagination totals #3307

Merged
merged 1 commit into from Oct 11, 2023

Conversation

DaddyWarbucks
Copy link
Member

This PR addresses the comments made at #2844.

When pagination is enabled, the total is now correct and essentially works as things used to. There are two changes from the original implementation.

1 - We check hasQuery before running the matcher. This is something I mentioned in my first PR. It just means that for our most basic calls like service.find() that we don't match the whole array for no reason.

2 - We now also add this.id in _select(value, params, this.id)). This ensures that the record ID is always selected, and is more in line with how most of the the DB adapters work. We may or may not want this, but its something to note as you guys are moving this over to Wings.

@daffl daffl changed the title Fix memory pagination fix(memory): Ensure correct pagination Oct 11, 2023
@daffl daffl changed the title fix(memory): Ensure correct pagination fix(memory): Ensure correct pagination totals Oct 11, 2023
@daffl daffl merged commit c59e1b8 into feathersjs:dove Oct 11, 2023
2 checks passed
@daffl
Copy link
Member

daffl commented Oct 11, 2023

Thank you for fixing that! Will go out shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants