Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): add typescript >=4.7 as peerDependency #3287

Merged
merged 1 commit into from Oct 3, 2023

Conversation

Artaud
Copy link
Contributor

@Artaud Artaud commented Sep 30, 2023

Schema package doesn't compile when installed TS is below 4.7, giving cryptic errors that are hard to track down. See https://discord.com/channels/509848480760725514/1079914294323445975 for context

Schema package doesn't compile when installed TS is below 4.7, giving cryptic errors that are hard to track down.
See https://discord.com/channels/509848480760725514/1079914294323445975 for context
@Artaud
Copy link
Contributor Author

Artaud commented Sep 30, 2023

This probably doesn't need any tests, should not be a breaking change (as projects without correct version TS do not compile anyway - AFAIK it doesn't compile even with "skipLibCheck": true in tsconfig.json).

Not sure if it needs any documentation changes, but I guess not.

The main reason for this change is (at least for me) that for Feathers projects that use the client lib on the frontend with Angular, the least version of Angular needed is 14, as 13 needs typescript < 4.7.
It is definitely not rare to be on a lower version currently, and projects that are cannot use Dove client lib.
However, when they try to update, the project doesn't compile, errors are cryptic, and there's no clear indication on what's going on. This change should make it clear.

@daffl daffl merged commit cb562ee into feathersjs:dove Oct 3, 2023
2 checks passed
@daffl
Copy link
Member

daffl commented Oct 3, 2023

That makes sense. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants