New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authentication-oauth): Properly handle all oAuth errors #3284

Merged

daffl merged 1 commit into dove from oauth-errors

Sep 27, 2023

Member

daffl commented Sep 27, 2023

This pull request ensures that Grant oAuth errors are properly handled. Thanks to @tjenkinson for finding this.

Closes oauth auth service still called even if grant returns an error #3275
Closes TypeError: Cannot read properties of undefined (reading 'sub') #3266
Closes Update strategy.ts #3267
Closes Broken authentication #3276


          fix(authentication-oauth): Properly handle all oAuth errors

655afdb

marshallswain approved these changes

View reviewed changes

tjenkinson commented Sep 27, 2023

Thanks!

daffl merged commit 148a9a3 into dove

4 checks passed

daffl deleted the oauth-errors branch

September 27, 2023 22:10

daffl mentioned this pull request

TypeError: Cannot read properties of undefined (reading 'sub') #3266

Closed

thiemogries mentioned this pull request

oauth ignores redirect url on error #3292

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment