Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] remove dependency on unmaintained rest-client library #21898

Merged
merged 4 commits into from Feb 29, 2024

Conversation

lacostej
Copy link
Collaborator

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #21689

Description

Testing Steps

@lacostej lacostej changed the title [Fix] remove dependency on unmaintained rest_client library [Fix] remove dependency on unmaintained rest-client library Feb 27, 2024
Copy link
Collaborator

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈🐐
It's about time. There are alternatives that don't break us 😄

@lacostej lacostej merged commit 33b2806 into master Feb 29, 2024
7 checks passed
@lacostej lacostej deleted the fix/remove_rest_client branch February 29, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ffi library in tests on Ruby 3.1 on Windows
2 participants