Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pilot] add xros as valid option for pilot upload #21841

Merged
merged 2 commits into from Feb 9, 2024

Conversation

demonnic
Copy link
Contributor

@demonnic demonnic commented Jan 30, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

The Apple Vision Pro headset officially releases this Friday, and currently the process I use for uploading apps to Apple is blocked because xros is not considered a supported platform by fastlane pilot

Description

This change adds xros as a valid option everywhere appletvos is mentioned for pilot, and also adjusts the specs. Prompted by the discussion #21802

I updated our resigning service to use my updated local copy of fastlane and was able to fastlane pilot upload our vision pro ipa with these changes.

Once this PR is ironed out I'm likely to take a look at adding it to the deliver in the hopes of maybe getting a release out ahead of or in line with the vision pro launch if at all possible.

Testing Steps

The command ultimately used to test the upload was bundle exec fastlane pilot upload --api-key-path <REDACTED> --skip_waiting_for_build_processing --team_id <REDACTED> --ipa <PATH/TO/IPA>

Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lacostej lacostej merged commit 1325533 into fastlane:master Feb 9, 2024
3 checks passed
@demonnic demonnic deleted the f/pilot/xrosAppstoreUploads branch February 9, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants