Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][OneSignal] Update to use v11.0 REST API #21839

Merged
merged 10 commits into from Jan 30, 2024

Conversation

Akramhussain4
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #21838

Description

Updated the OneSignal API to v11.0 and allow uploading a FCM service account JSON

@Akramhussain4
Copy link
Contributor Author

I'm not sure how to request a review as there's no option in this PR to do that. So, tagging @rogerluan and @AliSoftware here for a review please.

@AliSoftware
Copy link
Contributor

Thanks for tackling this and taking the time to contribute to fastlane! 👍 🙇

@AliSoftware AliSoftware merged commit 508e535 into fastlane:master Jan 30, 2024
3 checks passed
@lacostej lacostej changed the title Update OneSignal action to use v11.0 REST API [action][OneSignal] Update to use v11.0 REST API Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OneSignal action to use v11.0 REST API
2 participants