Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] fix devices fetch for tvOS platform #21828

Merged
merged 2 commits into from Feb 9, 2024

Conversation

nekrich
Copy link
Contributor

@nekrich nekrich commented Jan 23, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #21825.

Description

  1. Add check for :tvos platform.
  2. Skip adding filter if device_platforms is empty

Testing Steps

@nekrich nekrich changed the title match: fix devices fetch for tvOS paltform [match] fix devices fetch for tvOS paltform Jan 23, 2024
Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lacostej lacostej changed the title [match] fix devices fetch for tvOS paltform [match] fix devices fetch for tvOS platform Jan 24, 2024
@tache
Copy link
Contributor

tache commented Jan 26, 2024

This PR worked for me. TNX

@buscarini
Copy link

When is this PR going to be merged? I'm having this issue. Is there an easy way to install fastlane with this change applied? thanks!

@redreceipt
Copy link

What's the process/status on this PR being merged and included in a release? we need the fix as well

@lacostej lacostej merged commit 87151ca into fastlane:master Feb 9, 2024
3 checks passed
@lacostej
Copy link
Collaborator

lacostej commented Feb 9, 2024

When is this PR going to be merged? I'm having this issue. Is there an easy way to install fastlane with this change applied? thanks!

This was merged. if you use a Gemfile, you can easily point to the master branch of fastlane until we make a release, which hopefully should happen soon. We have one side issue to clarify.

@MartinGonzalez
Copy link
Contributor

Hi, I still have this issue on version 2.219.0. I'm using sigh

  "errors" : [ {
    "id" : "a823ac2d-48e3-4063-8248-a45b1156f503",
    "status" : "400",
    "code" : "PARAMETER_ERROR.INVALID",
    "title" : "A parameter has an invalid value",
    "detail" : "A parameter 'filter[platform]' has an invalid value : 'Empty filter values are not supported.'",
    "source" : {
      "parameter" : "filter[platform]"
    }
  } ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tvOS] Match: A parameter 'filter[platform]' has an invalid value : 'Empty filter values are not supported.
6 participants