fix the loading of certain passwords from the keychain (fixes #21817) #21818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a password contains certain characters (such as a backslash), the security command line tool will output the password in hexadecimal format followed by a quoted escaped string. Version 0.1.5 of the security gem supports this format, so updating to this version will make it so fastlane can properly load saved passwords that contain these special characters.
lacostej
approved these changes
Jan 18, 2024
| @@ -99,7 +99,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency('optparse', '>= 0.1.1', '< 1.0.0') # Used to parse options with Commander | |||
| spec.add_dependency('plist', '>= 3.1.0', '< 4.0.0') # Needed for set_build_number_repository and get_info_plist_value actions | |||
| spec.add_dependency('rubyzip', '>= 2.0.0', '< 3.0.0') # fix swift/ipa in gym | |||
| spec.add_dependency('security', '= 0.1.3') # macOS Keychain manager, a dead project, no updates expected | |||
| spec.add_dependency('security', '= 0.1.5') # macOS Keychain manager, a dead project, no updates expected | |||
There was a problem hiding this comment.
well so much for the "no updates expected".
I am also waiting for fastlane-community/security#12 to be merged and released :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a password contains certain characters (such as a backslash), the security command line tool will output the password in hexadecimal format followed by a quoted escaped string. Version 0.1.5 of the security gem supports this format, so updating to this version will make it so fastlane can properly load saved passwords that contain these special characters.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21817
Description
Updates the security gem to the latest version, from version 0.1.3 to 0.1.5.
I tested these changes by installing this version of fastlane, and then running
fastlane sigh download_allafter saving my account credentials to the keychain.Testing Steps
fastlane fastlane-credentials addand provide a password that contains a\fastlane sigh download_alland observe that the previously saved password is used for the login