Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][appetize] Raise error when the API returns an unsuccessful response #21816

Merged

Conversation

benferris-tl
Copy link
Contributor

@benferris-tl benferris-tl commented Jan 17, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #21786

Description

Adds a check for the response status code. Tested via unit test as well as with the Appetize API by running the action using an invalid token as described in #21786

Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benferris-tl for reporting the issue and fixing it :)

LGTM. Anyone else?

@lacostej lacostej merged commit 4a43eb2 into fastlane:master Feb 9, 2024
3 checks passed
@lacostej lacostej changed the title Raise error when Appetize API returns an unsuccessful response [action][appetize] Raise error when the API returns an unsuccessful response Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appetize action reports successful upload when upload has actually failed
2 participants