Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match][hotfix] remove the renew_expired_certs option introduced in #21691 and revert the default behavior while we address issues with it #21812

Merged
merged 3 commits into from Feb 10, 2024

Conversation

nekrich
Copy link
Contributor

@nekrich nekrich commented Jan 16, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Removes renew_expired_certs #21691, but behavior stays the same.
Doing this in favor of #21809, that doesn't require this option any more

Description

Testing Steps

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR, we need to carefully review whether we want to revert the feature (aka merge this PR) or merge your other one (that fixes it) 😬

Can you review my question below? 🙏

match/lib/match/runner.rb Outdated Show resolved Hide resolved
match/lib/match/runner.rb Outdated Show resolved Hide resolved
@nekrich
Copy link
Contributor Author

nekrich commented Jan 22, 2024

@rogerluan , sorry for the delay. Changed all to false and removed auto-renewal test.

@nekrich nekrich force-pushed the chore/remove-renew-certs-option branch from 83173f3 to 6ba32a2 Compare January 22, 2024 08:48
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a question. @lacostej I think this is good to go in case we need to deploy 😬 do you think we should merge it in and then revert it + fix the error in the other related PR?

match/lib/match/runner.rb Show resolved Hide resolved
match/lib/match/runner.rb Show resolved Hide resolved
@rogerluan rogerluan changed the title [match] remove the renew_expired_certs option and make behaviour default [match][hotfix] remove the renew_expired_certs option introduced in #21691 and revert the default behavior while we address issues with it Feb 10, 2024
@rogerluan rogerluan merged commit 9899046 into fastlane:master Feb 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants