Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an interactive console for users as well #21803

Merged
merged 4 commits into from Jan 13, 2024
Merged

Add an interactive console for users as well #21803

merged 4 commits into from Jan 13, 2024

Conversation

lacostej
Copy link
Collaborator

See #21800 - accidentally closed.

@lacostej
Copy link
Collaborator Author

Added some documentation. WDYT?

rogerluan
rogerluan requested changes Jan 13, 2024
View reviewed changes
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks about formatting but otherwise LGTM! I think this documentation is good enough 😊 maybe we could also add something to the docs repo, perhaps under /Advanced tab?

ToolsAndDebugging.md Outdated Show resolved Hide resolved
ToolsAndDebugging.md Outdated Show resolved Hide resolved
rogerluan
rogerluan reviewed Jan 13, 2024
View reviewed changes
ToolsAndDebugging.md Outdated Show resolved Hide resolved
rogerluan
rogerluan approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 🚀

@lacostej lacostej merged commit 21d0e79 into fastlane:master Jan 13, 2024
3 checks passed
@lacostej lacostej deleted the feature/console branch January 13, 2024 21:28
@rogerluan
Copy link
Member

@lacostej I think I just found a bug?

image

Steps to reproduce:

  1. bundle exec fastlane console
  2. Enter:
def hi
  puts "hi"
end
  1. Try running that method: hi
  2. 💥

Could this be something in my env? Are you able to define and access methods in your fastlane console?

@joshdholtz joshdholtz mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerluan rogerluan rogerluan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lacostej @rogerluan