Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhone 14 Frames #21727

Merged
merged 7 commits into from Jan 17, 2024
Merged

iPhone 14 Frames #21727

merged 7 commits into from Jan 17, 2024

Conversation

sathoeni
Copy link
Contributor

@sathoeni sathoeni commented Dec 14, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

As other pull request this fixes 'frameit' for the iPhone 14 Devices.
Unlike other pull requests it uses the correct devices size for iPhone 14 Pro.
Before framing the screenshots it applies a corner radius to the screenshot to fix the following issues
#20703
#20917

To merge this pull-request the following pull-request of 'frameit-frames' is required, because it provides the correct frame size for the iPhone14 Pro
Depends on: fastlane/frameit-frames#33

@sathoeni sathoeni force-pushed the master branch 4 times, most recently from 43456a1 to 0b6b438 Compare January 17, 2024 07:10
frameit/frames_generator/Rakefile Outdated Show resolved Hide resolved
@getaaron getaaron merged commit eccd410 into fastlane:master Jan 17, 2024
3 checks passed
@sathoeni
Copy link
Contributor Author

Thanks @getaaron 🥳
It would be awesome if you could also merge the corresponding frameit-frames pull request. This contains the fixed frame size in the offset definition
fastlane/frameit-frames#33

@getaaron
Copy link
Collaborator

Thanks for the reminder, @sathoeni, it's merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants