New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gym][fastlane_core] add platform support for visionOS #21574
Conversation
Thanks for this PR @PinkidG! We’d love to see this supported as well. ✨ Any chance for this to get merged @joshdholtz? 🙏 |
...xamples/visionos/Packages/RealityKitContent/Package.realitycomposerpro/ProjectData/main.json
Outdated
Show resolved
Hide resolved
@lacostej is there anything else that needs to be done here in order to land this in a release? 🚀 |
@lacostej any chance of getting this merged into the next Fastlane release now that visionOS submissions are open and the SDK is out of beta with Xcode 15.2? 🙏 @PinkidG maybe you could rebase this onto master to make sure everything passes with the latest changes? |
Our dev teams would love to have proper visionOS support in fastlane. @lacostej or @rogerluan is there anything else required to get this merged? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution @PinkidG ! 🙌 I really appreciate you adding the demo project for the integration test, this is really helpful. I haven't done any work with visionOS yet so I don't understand some of those 3D model and scene files that you added but I'm sure it's ok for integration testing purposes :)
Looking forward to seeing great visionOS apps being built! 🚀
Since the question came up in discussions: does this PR also unlock visionOS support for deliver (e.g. uploading visionOS binaries to the App Store)? |
Replied in the discussion @triplef 🙇 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
With the upcoming release of the Vision Pro, we'll have a new platform that gym needs to support. While the device uses the same architecture as iOS devices, it does have its own platforms (
xros
,xrsimulator
)Description
Added a new platform identifier and cases to
project.rb
make sure that new cases are considered in gym.