Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gym][fastlane_core] add platform support for visionOS #21574

Merged
merged 12 commits into from Jan 18, 2024

Conversation

PinkidG
Copy link
Contributor

@PinkidG PinkidG commented Oct 12, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

With the upcoming release of the Vision Pro, we'll have a new platform that gym needs to support. While the device uses the same architecture as iOS devices, it does have its own platforms (xros, xrsimulator)

Description

Added a new platform identifier and cases to project.rb make sure that new cases are considered in gym.

@PinkidG PinkidG marked this pull request as ready for review October 12, 2023 19:55
@triplef
Copy link
Contributor

triplef commented Nov 14, 2023

Thanks for this PR @PinkidG! We’d love to see this supported as well. ✨

Any chance for this to get merged @joshdholtz? 🙏

@triplef
Copy link
Contributor

triplef commented Dec 16, 2023

@PinkidG any chance you could incorporate the feedback from @lacostej? Would be amazing to see this merged soon with Apple seemingly getting ready for launch of the platform. 🙏

@triplef
Copy link
Contributor

triplef commented Dec 27, 2023

@lacostej is there anything else that needs to be done here in order to land this in a release? 🚀

@triplef
Copy link
Contributor

triplef commented Jan 8, 2024

@lacostej any chance of getting this merged into the next Fastlane release now that visionOS submissions are open and the SDK is out of beta with Xcode 15.2? 🙏

@PinkidG maybe you could rebase this onto master to make sure everything passes with the latest changes?

@PinkidG
Copy link
Contributor Author

PinkidG commented Jan 17, 2024

Our dev teams would love to have proper visionOS support in fastlane.

@lacostej or @rogerluan is there anything else required to get this merged?

Thanks!

@rogerluan rogerluan changed the title [gym] Adding platform support for visionOS [gym] add platform support for visionOS Jan 18, 2024
gym/lib/gym/module.rb Outdated Show resolved Hide resolved
gym/examples/visionos/Packages/RealityKitContent/README.md Outdated Show resolved Hide resolved
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @PinkidG ! 🙌 I really appreciate you adding the demo project for the integration test, this is really helpful. I haven't done any work with visionOS yet so I don't understand some of those 3D model and scene files that you added but I'm sure it's ok for integration testing purposes :)

Looking forward to seeing great visionOS apps being built! 🚀

@rogerluan rogerluan changed the title [gym] add platform support for visionOS [gym][fastlane_core] add platform support for visionOS Jan 18, 2024
@rogerluan rogerluan merged commit 39ed6fe into fastlane:master Jan 18, 2024
3 checks passed
@triplef
Copy link
Contributor

triplef commented Jan 24, 2024

Since the question came up in discussions: does this PR also unlock visionOS support for deliver (e.g. uploading visionOS binaries to the App Store)?

@rogerluan
Copy link
Member

Replied in the discussion @triplef 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants