Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] Fixes missing job-token error in GitLab storage mode #21520

Merged

Conversation

darbyfrey
Copy link
Contributor

@darbyfrey darbyfrey commented Sep 18, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

This PR fixes the error reported in #21018 (comment) related to the GitLab Secure Files Fastlane Match storage backend.

Description

The error was introduced in this change #21018 which added an additional configuration keys check that didn't exist before. This issue is resolved by adding the optional configuration keys to the global configuration object so that the keys can be validated correctly.

Testing Steps

Tested locally and added automated tests.

@darbyfrey
Copy link
Contributor Author

@getaaron @joshdholtz this PR fixes #21018 (comment), could you take a look when you have a moment? Thanks!

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! 🙌

@getaaron getaaron merged commit 27dc84d into fastlane:master Sep 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants