Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request retry with backoff when encountring 429 errors #21511

Merged
merged 2 commits into from Sep 15, 2023

Conversation

snatchev
Copy link
Member

@snatchev snatchev commented Sep 14, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Fixes #13841

This PR attempts to handle 429 "Too Many Requests" errors when using the App Store Connect API. The default request quota offered by the App Store Connect API is 3600 / hour. Requests will back off, with doubling delays, until 3600 seconds is reach after which it will give up.

Description

Testing Steps

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! 😊 And makes total sense 💪

@joshdholtz joshdholtz merged commit c04f975 into fastlane:master Sep 15, 2023
10 checks passed
@snatchev
Copy link
Member Author

Thank you so much @joshdholtz!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants