Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] deprecate the ensure_xcode_version action #21448

Merged
merged 1 commit into from Aug 26, 2023

Conversation

revolter
Copy link
Collaborator

@revolter revolter commented Aug 8, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

I saw that this action also depends on the xcode-install gem:

Actions.verify_gem!('xcode-install')

similar to xcversion:

Actions.verify_gem!('xcode-install')

so it should be deprecated as well.

Description

Testing Steps

@getaaron getaaron merged commit 6c76839 into master Aug 26, 2023
9 checks passed
@rogerluan rogerluan deleted the revolter/deprecate-ensure-xcode-version branch September 16, 2023 03:28
@rogerluan
Copy link
Member

Sorry I'm late to reviewing this PR, I wasn't aware of it 😬 I just saw it in the release notes of fastlane. There was a reason this action wasn't deprecated before, and it's explained in the migration guide: https://github.com/xcpretty/xcode-install/blob/master/MIGRATION.md#3-ensure_xcode_version

Long story short, depending on how you use ensure_xcode_version, it may not be possible to migrate to xcodes.

Do we still want to keep this action marked as deprecated? 🤔 @revolter @getaaron

@revolter
Copy link
Collaborator Author

Oh, I didn't know 😱

I can revert this, and instead, only add a short bit in the description stating that it's deprecated if you use strict: true.

@revolter
Copy link
Collaborator Author

Or, to push things forward instead, if no one complained, maybe the majority already migrated and/or are not using (anymore) strict: false 🤔

Otherwise, we force ourselves to keep this sort of deprecated action for a longer time.

@rogerluan
Copy link
Member

if no one complained

The release went out only a few hours ago, and it's a friday night/saturday 😅

But my gut feeling is that not a lot of people use this action with strict: false anyway 🤷 but this shouldn't be our MO regardless, I think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants