[docs] update pull request template to ask contributors to write unit tests #21427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerluan
commented
Jul 28, 2023
| @@ -1,22 +1,26 @@ | |||
| <!-- Thanks for contributing to _fastlane_! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) --> | |||
|
|
|||
| ### Checklist | |||
|
|
|||
There was a problem hiding this comment.
I added these line breaks as it's a markdown good practice to surround headers with line breaks (before and after), as some markdown interpreters don't parse them correctly when there are no line breaks after headers
getaaron
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
Lots of contributors open PRs without updating or adding unit tests, which means we (reviewers) end up submitting a review just to ask the PR author to add unit tests.
PRs that have unit tests are much easier and faster to be reviewed, and thus approved and merged.