Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] Fixes Gitlab Secure Files API limit #21361

Merged

Conversation

darbyfrey
Copy link
Contributor

@darbyfrey darbyfrey commented Jun 26, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This PR finishes the changes that were started in #21205

Resolves #21204

This change fixes an issue for those people who have many different certs/provision profiles/keys stored on Gitlab in a "Secure files" section. The api used currently by Fastlane does not take into account paging and it's capable of downloading only 20 such files instead of all of them (max 100). This leads to signing issues as some files might be missing.

Description

Testing Steps

@google-cla
Copy link

google-cla bot commented Jun 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@getaaron getaaron merged commit 37f2f6c into fastlane:master Jul 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[match] Gitlab Secure files API limited to 20 files by default
2 participants