New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel #21284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
force-pushed
the
joshdholtz-sim-rosetta-xcode-14.3
branch
from
May 17, 2023 11:47
34122df
to
26eb4c1
Compare
joshdholtz
changed the title
[scan][snapshot] Run simulator in Rosetta for Xcode 14.3 and up
[scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel
May 17, 2023
4 tasks
rogerluan
reviewed
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my 馃く So glad I found this 馃槀 I was about to create a PR to address this very same issue! Thank you @joshdholtz! 鉂わ笍
4 tasks
markhomoki
added a commit
to markhomoki/fastlane
that referenced
this pull request
Jul 5, 2023
Improvements * [core][match] remove obsolete and expired WWDR G1 certificate (fastlane#21271) via Frederik Seiffert (@triplef) * [action][ensure_git_status_clean] new ignore_files option for explicitly ignoring files (fastlane#21283) via Josh Holtz (@joshdholtz) * [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel (fastlane#21284) via Josh Holtz (@joshdholtz) * [match] adding support for self-managed GitLab instances (fastlane#21274) via Darby Frey (@darbyfrey) * [pilot] fix increase limit for build query (fastlane#21212) via Eric Lindvall (@eric) * [dependency] relax `multipart_post` dependency version requirement (fastlane#20870) via Edouard Bri猫re (@edouard) https://github.com/fastlane/fastlane/releases/tag/2.213.0
6 tasks
smalbs
added a commit
to potatotrain/fastlane
that referenced
this pull request
Nov 16, 2023
* commit '0ede7e768d97d7e22e576d72ab8de96272c479a5': Version bump to 2.213.0 (fastlane#21286) [core] Remove obsolete and expired WWDR G1 certificate (fastlane#21271) [action][ensure_git_status_clean] new ignore_files option for explicitly ignoring files (fastlane#21283) [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel (fastlane#21284) [match] Adding support for self-managed GitLab instances (fastlane#21274) [pilot] Fix increase limit for build query (fastlane#21212) [dependency] relax `multipart_post` dependency version requirement (fastlane#20870)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #21194
Description
Force simulator destination to
arch=x86_86
if:run_rosetta_simulator
option is set totrue
Testing Steps
Update
Gemfile
to 馃憞 and runbundle install
,bundle update fastlane
, orbundle update