Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel #21284

Merged
merged 3 commits into from May 17, 2023

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented May 17, 2023

Motivation and Context

Fixes #21194

Description

Force simulator destination to arch=x86_86 if :run_rosetta_simulator option is set to true

scan(run_rosetta_simulator: true)

Testing Steps

Update Gemfile to 馃憞 and run bundle install, bundle update fastlane, or bundle update

gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "joshdholtz-sim-rosetta-xcode-14.3"

@joshdholtz joshdholtz force-pushed the joshdholtz-sim-rosetta-xcode-14.3 branch from 34122df to 26eb4c1 Compare May 17, 2023 11:47
@joshdholtz joshdholtz changed the title [scan][snapshot] Run simulator in Rosetta for Xcode 14.3 and up [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel May 17, 2023
@joshdholtz joshdholtz marked this pull request as ready for review May 17, 2023 12:32
@joshdholtz joshdholtz mentioned this pull request May 17, 2023
4 tasks
@joshdholtz joshdholtz merged commit 586b13f into master May 17, 2023
9 checks passed
@rogerluan rogerluan deleted the joshdholtz-sim-rosetta-xcode-14.3 branch May 18, 2023 03:48
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 馃く So glad I found this 馃槀 I was about to create a PR to address this very same issue! Thank you @joshdholtz! 鉂わ笍

markhomoki added a commit to markhomoki/fastlane that referenced this pull request Jul 5, 2023
Improvements

* [core][match] remove obsolete and expired WWDR G1 certificate (fastlane#21271) via Frederik Seiffert (@triplef)
* [action][ensure_git_status_clean] new ignore_files option for explicitly ignoring files (fastlane#21283) via Josh Holtz (@joshdholtz)
* [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel (fastlane#21284) via Josh Holtz (@joshdholtz)
* [match] adding support for self-managed GitLab instances (fastlane#21274) via Darby Frey (@darbyfrey)
* [pilot] fix increase limit for build query (fastlane#21212) via Eric Lindvall (@eric)
* [dependency] relax `multipart_post` dependency version requirement (fastlane#20870) via Edouard Bri猫re (@edouard)

https://github.com/fastlane/fastlane/releases/tag/2.213.0
smalbs added a commit to potatotrain/fastlane that referenced this pull request Nov 16, 2023
* commit '0ede7e768d97d7e22e576d72ab8de96272c479a5':
  Version bump to 2.213.0 (fastlane#21286)
  [core] Remove obsolete and expired WWDR G1 certificate (fastlane#21271)
  [action][ensure_git_status_clean] new ignore_files option for explicitly ignoring files (fastlane#21283)
  [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel (fastlane#21284)
  [match] Adding support for self-managed GitLab instances (fastlane#21274)
  [pilot] Fix increase limit for build query (fastlane#21212)
  [dependency] relax `multipart_post` dependency version requirement (fastlane#20870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 14.3 Rosetta Simulators
2 participants