New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deliver] Update upload_price_tier #21282
Conversation
ng tier election to correctly handle nil value
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
👍 Works for me with this change |
Please, could anyone let this proceed, then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll get a new version out tonight
Thanks for the fix! ❤️
I'm sorry, but as I wrote (#21213 (comment)) in the very similar #21213, I don't think this fix is correct. This will probably end up making any app available in all territories. |
ng tier election to correctly handle nil value
Thank you for releasing this as part of 2.214.0! |
I can confirm what @vincentisambart is saying. This is setting our apps to be available in all territories every time we submit and we have to manually change it. |
Updates Pricing tier selection to correctly handle nil value
Motivation and Context
Resolves #21236
Description
This change adds safe nav operator to prevent NoMethodErrors when checking first app price, preventing failure to set pricing tier for new app listings.
Tested via creation of several new dummy apps to verify the pricing is set as expected.
Testing Steps