Adding support for self-managed GitLab instances #21274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @getaaron, I've got an update on the gitlab backend here, mind giving it a look when you have some time? |
getaaron
approved these changes
May 13, 2023
markhomoki
added a commit
to markhomoki/fastlane
that referenced
this pull request
Jul 5, 2023
Improvements * [core][match] remove obsolete and expired WWDR G1 certificate (fastlane#21271) via Frederik Seiffert (@triplef) * [action][ensure_git_status_clean] new ignore_files option for explicitly ignoring files (fastlane#21283) via Josh Holtz (@joshdholtz) * [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel (fastlane#21284) via Josh Holtz (@joshdholtz) * [match] adding support for self-managed GitLab instances (fastlane#21274) via Darby Frey (@darbyfrey) * [pilot] fix increase limit for build query (fastlane#21212) via Eric Lindvall (@eric) * [dependency] relax `multipart_post` dependency version requirement (fastlane#20870) via Edouard Brière (@edouard) https://github.com/fastlane/fastlane/releases/tag/2.213.0
smalbs
added a commit
to potatotrain/fastlane
that referenced
this pull request
Nov 16, 2023
* commit '0ede7e768d97d7e22e576d72ab8de96272c479a5': Version bump to 2.213.0 (fastlane#21286) [core] Remove obsolete and expired WWDR G1 certificate (fastlane#21271) [action][ensure_git_status_clean] new ignore_files option for explicitly ignoring files (fastlane#21283) [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel (fastlane#21284) [match] Adding support for self-managed GitLab instances (fastlane#21274) [pilot] Fix increase limit for build query (fastlane#21212) [dependency] relax `multipart_post` dependency version requirement (fastlane#20870)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR resolves this issue by adding a config option for
gitlab_host. The option defaults to the gitlab.com host, but can be configured for folks running self-managed gitlab instances.Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
The first iteration of the gitlab_secure_files storage backend only supported gitlab.com since that feature wasn't available for self managed instances. It's now been available for several months, so it's about time we added support here as well. This limitation was also reported in #21197.
Description
This change adds an additional configuration set to the
match initprocess and adds thegitlab_hostoption to theMatchfileTesting Steps
You can test this change by running
fastlane match initand verifying that thegitlab_hostoption is written to theMatchfileThe configuration is also printed in the output when running
fastlane match. For example: