[core] Remove obsolete and expired WWDR G1 certificate #21271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI these two tests failed for me locally (both with |
4 tasks
thehale
reviewed
May 12, 2023
| @@ -55,7 +55,6 @@ class ProcessStatusMock | |||
| describe '#install_missing_wwdr_certificates' do | |||
| it 'should install all official WWDR certificates' do | |||
| allow(FastlaneCore::CertChecker).to receive(:installed_wwdr_certificates).and_return([]) | |||
| expect(FastlaneCore::CertChecker).to receive(:install_wwdr_certificate).with('G1') | |||
There was a problem hiding this comment.
Does this deletion (and the others like it later in the PR) assert that the G1 is absent from the set of installed certs? OR does it merely stop caring about the G1?
I'd imagine we want the first.
NOTE: I have little experience with Ruby development, so my concern here may be unfounded.
joshdholtz
approved these changes
May 17, 2023
philipphofmann
added a commit
to getsentry/sentry-cocoa
that referenced
this pull request
May 25, 2023
Remove pinned Fastlane version as 2.213.0 contains a possible fix for WWDC certificate error, see fastlane/fastlane#21271.
philipphofmann
added a commit
to getsentry/sentry-cocoa
that referenced
this pull request
May 26, 2023
Remove pinned Fastlane version as 2.213.0 contains a possible fix for WWDC certificate error, see fastlane/fastlane#21271.
markhomoki
added a commit
to markhomoki/fastlane
that referenced
this pull request
Jul 5, 2023
Improvements * [core][match] remove obsolete and expired WWDR G1 certificate (fastlane#21271) via Frederik Seiffert (@triplef) * [action][ensure_git_status_clean] new ignore_files option for explicitly ignoring files (fastlane#21283) via Josh Holtz (@joshdholtz) * [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel (fastlane#21284) via Josh Holtz (@joshdholtz) * [match] adding support for self-managed GitLab instances (fastlane#21274) via Darby Frey (@darbyfrey) * [pilot] fix increase limit for build query (fastlane#21212) via Eric Lindvall (@eric) * [dependency] relax `multipart_post` dependency version requirement (fastlane#20870) via Edouard Brière (@edouard) https://github.com/fastlane/fastlane/releases/tag/2.213.0
smalbs
added a commit
to potatotrain/fastlane
that referenced
this pull request
Nov 16, 2023
* commit '0ede7e768d97d7e22e576d72ab8de96272c479a5': Version bump to 2.213.0 (fastlane#21286) [core] Remove obsolete and expired WWDR G1 certificate (fastlane#21271) [action][ensure_git_status_clean] new ignore_files option for explicitly ignoring files (fastlane#21283) [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel (fastlane#21284) [match] Adding support for self-managed GitLab instances (fastlane#21274) [pilot] Fix increase limit for build query (fastlane#21212) [dependency] relax `multipart_post` dependency version requirement (fastlane#20870)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21269.
Description
The WWDR G1 CA expired on Feb 7, 2023 and is no longer listed on the Apple PKI website.
Testing Steps
bundle exec fastlane match.