New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] add update method to ConnectAPI::User #20956
Conversation
@revolter , sorry for the ping, but if there is something I can improve? |
@joshdholtz , do I have any chances you review this PR🙏 ? |
@ainame , @rogerluan , any kind of feedback is appreciated 🙏 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Left some questions though 🙏
Thank you for this contribution @nekrich !
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I don't have experience with this part of the app, so I can't say much (except some nitpicking) 😞
All the changes do make sense to me, though, and I trust that you actually tested them 💪🏻
Also, it doesn't look like it could break anything, but I'm not sure, so I'd wait for @joshdholtz to take a look too 😟
Co-authored-by: Iulian Onofrei <5748627+revolter@users.noreply.github.com>
Any chances of merging this? |
I took another look, and, again, it doesn't look like it could break existing logic, it rather adds new logic, so I will merge this. |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
We want to have the ability to change user roles and app access. And for that, we need Modify a User Account
API implemented.
Description
update
or describe changes using parameters.UserInvitation.create
docs.User.update
&UserInvitation.requests
if all apps are allowed to reduce the number of API errors.Testing Steps