[dependency] relax multipart_post dependency version requirement
#20870
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Is there any way to restart the CI check on AppVeyvor? It failed for some reason but cannot restart it. |
| @@ -78,7 +78,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency('plist', '>= 3.1.0', '< 4.0.0') # Needed for set_build_number_repository and get_info_plist_value actions | |||
| spec.add_dependency('CFPropertyList', '>= 2.3', '< 4.0.0') # Needed to be able to read binary plist format | |||
| spec.add_dependency('addressable', '>= 2.8', '< 3.0.0') # Support for URI templates | |||
| spec.add_dependency('multipart-post', '~> 2.0.0') # Needed for uploading builds to appetize | |||
| spec.add_dependency('multipart-post', '>= 2.0.0', '< 3.0.0') # Needed for uploading builds to appetize | |||
There was a problem hiding this comment.
Initially, I thought ~> 2.0.0 and >= 2.0.0, < 3.0.0 were equivalent, but I see the difference now. I suppose we could change ~> 2.0.0 to ~> 2, which is simpler, but that would go against the code style pattern being used nearly-throughout this file so I think this is better :)
There was a problem hiding this comment.
Yes, I followed the style I saw in the rest of that .gemspec file.
|
@edouard could you rebase this branch, to trigger CI again, please? 🙏 |
edouard
force-pushed
the
relax-multipart_post-dependency
branch
from
5b6233f
to
e5b6540
Compare
edouard
force-pushed
the
relax-multipart_post-dependency
branch
from
e5b6540
to
8fdfdf2
Compare
Done! Thank you for reviewing it! |
rogerluan
changed the title
multipart_post dependency version requirement
Improvements * [core][match] remove obsolete and expired WWDR G1 certificate (fastlane#21271) via Frederik Seiffert (@triplef) * [action][ensure_git_status_clean] new ignore_files option for explicitly ignoring files (fastlane#21283) via Josh Holtz (@joshdholtz) * [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel (fastlane#21284) via Josh Holtz (@joshdholtz) * [match] adding support for self-managed GitLab instances (fastlane#21274) via Darby Frey (@darbyfrey) * [pilot] fix increase limit for build query (fastlane#21212) via Eric Lindvall (@eric) * [dependency] relax `multipart_post` dependency version requirement (fastlane#20870) via Edouard Brière (@edouard) https://github.com/fastlane/fastlane/releases/tag/2.213.0
* commit '0ede7e768d97d7e22e576d72ab8de96272c479a5': Version bump to 2.213.0 (fastlane#21286) [core] Remove obsolete and expired WWDR G1 certificate (fastlane#21271) [action][ensure_git_status_clean] new ignore_files option for explicitly ignoring files (fastlane#21283) [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and up if on Intel (fastlane#21284) [match] Adding support for self-managed GitLab instances (fastlane#21274) [pilot] Fix increase limit for build query (fastlane#21212) [dependency] relax `multipart_post` dependency version requirement (fastlane#20870)
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
The gem
multipart_postis currently set to~> 2.0.0on fastlane. Since2.0.0is the only version released on the2.0series, it effectively locksmultipart_postto2.0.0which is a version that was released in 2013. When users bundle fastlane with other dependencies (for instance with the web_translate_it gem which requires a newer version ofmultipart_post), runningbundlefails. See webtranslateit/webtranslateit#212 and webtranslateit/webtranslateit#220We’ve mitigated the issue on our end by relaxing our dependency to multipart_post to let users use older versions, but this almost 10 years old dependency should be updated on your side as well.
Description
I've relaxed the dependency on
multipart_postin the gemspec file. I've checked where multipart_post is used on the code and I haven’t noted any changes required in the code.Testing Steps