ensure_git_status_clean documentation confusing wording for ignored parameter

[simondelphia]

https://docs.fastlane.tools/actions/ensure_git_status_clean/

For the parameter ignored the description says "The flag whether to ignore file the git status if the repo is dirty"

I'm not clear on what that means. Looks like a typo.

Thank you

[fastlane-bot]

It seems like you have not included the output of fastlane env
To make it easier for us help you resolve this issue, please update the issue to include the output of fastlane env 👍

[lucgrabowski]

It looks like you're right, it's not a bool flag, it's a string parameter. git status docs should be helpful to understand how to use it

fastlane/fastlane/lib/fastlane/actions/ensure_git_status_clean.rb

Lines 8 to 15 in e215bdc

	class EnsureGitStatusCleanAction < Action
	def self.run(params)
	if params[:ignored]
	ignored_file = params[:ignored]
	repo_status = Actions.sh("git status --porcelain --ignored #{ignored_file}")
	else
	repo_status = Actions.sh("git status --porcelain")
	end

[tcf909]

Actually, even worse is the actual command being run is wrong.

It needs to be:

git status --porcelain --ignored=#{ignored_file}

if you run it without the equals sign it basically always comes back as empty because it is using "no" as the ... for the git-status command.

I would consider this a show stopper (critical). The consequence: if you use it with reset_git_repo you will lose all uncommitted changes because the gate of a block being (ensure_git_status_clean) will always allow the process to flow through it ie:

ensure_git_status_clean(
  ignored: 'no'
)

begin

  ...

ensure

  reset_git_repo(
    disregard_gitignore: false,
  )

  # Potentially all uncommitted files lost now because ensure_git_status_clean did not raise correctly

end

[fastlane-bot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

[simondelphia]

Still an issue

[fastlane-bot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

[simondelphia]

Still an issue

[fastlane-bot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

[simondelphia]

still an issue

[Ryabchikus]

I'm here too
I can't exclude some files from git check

[fastlane-bot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

This issue will be auto-closed if there is no reply within 1 month.

[simondelphia]

still an issue

[ObjectiveCesar]

And still an issue.

The PR to at least fix the documentation issue is open here: #20976

But imho the underlaying issue still persists.

[revolter]

I can rename that PR and also fix the issue. Would you be willing to test it? As I'm not currently using that action.

[ObjectiveCesar]

I can rename that PR and also fix the issue. Would you be willing to test it? As I'm not currently using that action.

I could try at least. Never built fastlane from source so far. :)

[revolter]

You don't have to 😁 I added the testing steps in the PR description