fix: response headers serialization #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
reviewed
Jun 7, 2023
lib/response.js
Outdated
| response._lightMyRequest.headers = Object.assign({}, response.getHeaders()) | ||
| const headers = Object.assign({}, response.getHeaders()) | ||
|
|
||
| for (const [name, value] of Object.entries(headers)) { |
There was a problem hiding this comment.
How is the performance of this?
There was a problem hiding this comment.
It would be better to use Object.keys() instead.
mcollina
reviewed
Jun 7, 2023
|
I pushed a fixup commit. Idk where it is. |
ivan-tymoshenko
force-pushed
the
fix-response-headers-serialization
branch
from
ef335f1
to
babe2a8
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.