Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: specify separate targets for dev and production #572

Merged
merged 4 commits into from
Feb 8, 2024
Merged

feat: specify separate targets for dev and production #572

merged 4 commits into from
Feb 8, 2024

Conversation

groozin
Copy link
Contributor

@groozin groozin commented Feb 8, 2024 •
edited

Fixes #443.

Sample configuration, copied from Readme:

steps:
  - uses: fastify/github-action-merge-dependabot@v3
    with:
      target-development: 'major'
      target-production: 'minor'

Checklist

@groozin groozin changed the title feat: specify separate targets for dev and production (#443) feat: specify separate targets for dev and production Feb 8, 2024
@groozin groozin force-pushed the feat/specify-separate-targets-for-dev-and-production branch from 4eba486 to 3c8ea53 Compare February 8, 2024 11:56
@groozin groozin force-pushed the feat/specify-separate-targets-for-dev-and-production branch from 3c8ea53 to 71134f6 Compare February 8, 2024 12:00
@groozin groozin marked this pull request as ready for review February 8, 2024 12:16
PhanindraNeralla
PhanindraNeralla reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@PhanindraNeralla PhanindraNeralla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

simoneb
simoneb requested changes Feb 8, 2024
View reviewed changes
action.yml Outdated Show resolved Hide resolved
src/action.js Outdated Show resolved Hide resolved
@groozin groozin requested a review from simoneb February 8, 2024 15:46
simoneb
simoneb approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simoneb simoneb merged commit 9898c72 into fastify:main Feb 8, 2024
3 checks passed
@optic-release-automation optic-release-automation bot mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhanindraNeralla PhanindraNeralla PhanindraNeralla left review comments

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different targets for development and production dependencies
3 participants
@groozin @simoneb @PhanindraNeralla