fix: merge status output not working #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
force-pushed
the
merge-status-output
branch
from
4bc164b
to
1eb63b6
Compare
simoneb
force-pushed
the
merge-status-output
branch
from
1eb63b6
to
896797a
Compare
simoneb
changed the title
* Fixes dependabot/output-doesnot-seem-to-appear#539 * #539 adding random merge status key to verify * #539 adding random merge status keys * #539 removed log messages. Added workflow id to workflow * #539 added workflow id to action yaml * #539 removed unneeded changes in action yaml file * fix #539 added new merge status for auto merge
|
@climba03003 @Fdawgs could use a review here please |
Eomm
approved these changes
Feb 9, 2024
action.yml
Outdated
| @@ -53,6 +58,7 @@ runs: | |||
| skip-verification : ${{ inputs.skip-verification }} | |||
| - name: Merge/approve PR | |||
| uses: actions/github-script@v7 | |||
| id: main | |||
There was a problem hiding this comment.
Suggested change
| id: main | |
| id: approver |
action.yml
Outdated
| outputs: | ||
| merge_status: | ||
| description: "Merge status" | ||
| value: ${{ steps.main.outputs.merge_status }} |
There was a problem hiding this comment.
Suggested change
| value: ${{ steps.main.outputs.merge_status }} | |
| value: ${{ steps.approver.outputs.merge_status }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #539. Basically there were issues:
Checklist
npm run testandnpm run benchmarkand the Code of conduct