onReady might be executed twice

[mcollina]

If we call ready() in parallel, the onReady hooks are triggered twice

import fastify from './fastify.js'

const app = fastify()

app.addHook('onReady', async function () {
  console.log('onReady')
})


await Promise.race([app.ready(), app.ready()])

await app.ready()

Note that this is also a problem when using inject()

[saikiran76]

You are correct that calling ready() in parallel can cause the onReady hooks to be triggered twice. This is because onReady hooks are triggered once for each call to be ready().

To avoid this issue, you can use a boolean flag to ensure that the onReady hooks are only triggered once. Here's an example:

import fastify from './fastify.js'

const app = fastify()

let isReady = false

app.addHook('onReady', async function () {
if (!isReady) {
console.log('onReady')
isReady = true
}
})

await Promise.race([app.ready(), app.ready()])

await app.ready()

[saikiran76]

If the above seems it can work, may be I will be able to work on this. @mcollina

[mcollina]

Yes... but it's likely going to be more tricky than that example.