Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize dirList #435

Merged
merged 3 commits into from Feb 6, 2024
Merged

Optimize dirList #435

merged 3 commits into from Feb 6, 2024

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Feb 6, 2024

dirList methods are potentially called on each request to a resource

It had a high number of inline functions that are independent of their scope, which might make it difficult for V8 to optimize them

This PR simply extracts those functions so that they're created once and can be better optimized; it also switches to fastq by @mcollina from p-limit

@gurgunday gurgunday requested a review from a team February 6, 2024 10:10
lib/dirList.js Outdated Show resolved Hide resolved
Co-authored-by: KaKa <23028015+climba03003@users.noreply.github.com>
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
@gurgunday gurgunday merged commit cd85aca into fastify:master Feb 6, 2024
19 checks passed
@gurgunday gurgunday deleted the optimize branch February 6, 2024 10:38
ddadaal pushed a commit to PKUHPC/SCOW that referenced this pull request Feb 18, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/static](https://togithub.com/fastify/fastify-static) |
[`6.12.0` ->
`7.0.1`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.12.0/7.0.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.12.0/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.12.0/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-static (@&#8203;fastify/static)</summary>

###
[`v7.0.1`](https://togithub.com/fastify/fastify-static/releases/tag/v7.0.1)

[Compare
Source](https://togithub.com/fastify/fastify-static/compare/v7.0.0...v7.0.1)

#### What's Changed

- build(deps-dev): bump
[@&#8203;fastify/compress](https://togithub.com/fastify/compress) from
6.5.0 to 7.0.0 by [@&#8203;dependabot](https://togithub.com/dependabot)
in
[fastify/fastify-static#433
- Optimize `dirList` by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#435
- fix: file not found errors when the root has a trailing slash by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#436

**Full Changelog**:
fastify/fastify-static@v7.0.0...v7.0.1

###
[`v7.0.0`](https://togithub.com/fastify/fastify-static/releases/tag/v7.0.0)

[Compare
Source](https://togithub.com/fastify/fastify-static/compare/v6.12.0...v7.0.0)

#### What's Changed

- build(deps-dev): bump tsd from 0.29.0 to 0.30.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify-static#424
- docs(readme): replace `fastify.io` links with `fastify.dev` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-static#425
- docs(readme): replace `fastify.io` links with `fastify.dev` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-static#426
- chore(package): fix repository url by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-static#429
- chore: improve types for `setHeaders` option by
[@&#8203;EvanHahn](https://togithub.com/EvanHahn) in
[fastify/fastify-static#428
- Upgrade glob to v10 by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify-static#406

#### New Contributors

- [@&#8203;EvanHahn](https://togithub.com/EvanHahn) made their first
contribution in
[fastify/fastify-static#428

**Full Changelog**:
fastify/fastify-static@v6.12.0...v7.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on sunday" in timezone Asia/Shanghai,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/PKUHPC/SCOW).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants