vary origin on delegated options #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saschanaz could you review as well? How much of this PR is reverting the original change? |
The spirit of the original change is still there, that when we have a static or '*' origin then we should not add the vary header. It's just that dynamic config through a callback can make the origin dynamic. The other dynamic config possibilities was handled in the original PR. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
climba03003
requested changes
Jan 27, 2024
saschanaz
approved these changes
Jan 27, 2024
Eomm
reviewed
Jan 28, 2024
| } | ||
| }) | ||
| } | ||
|
|
||
| /** | ||
| * @param {import('./types').FastifyCorsOptions} opts | ||
| */ | ||
| function normalizeCorsOptions (opts) { | ||
| function normalizeCorsOptions (opts, dynamic) { |
There was a problem hiding this comment.
function normalizeCorsOptions (opts, dynamic = false) {
Eomm
reviewed
Jan 28, 2024
| @@ -148,11 +148,12 @@ function normalizeCorsOptions (opts) { | |||
| // strings are applied directly and any other value is ignored | |||
| corsOptions.cacheControl = null | |||
| } | |||
| corsOptions.dynamic = dynamic || false | |||
There was a problem hiding this comment.
Late to the party:
why didn't we set it during the declaration?
|
@Eomm |
|
Yeah, but it is not released 😈 |
|
Can it be released soon though? |
|
shipped |
renovate bot
added a commit
to tomacheese/telcheck
that referenced
this pull request
Feb 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/cors](https://togithub.com/fastify/fastify-cors) | [`9.0.0` -> `9.0.1`](https://renovatebot.com/diffs/npm/@fastify%2fcors/9.0.0/9.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-cors (@​fastify/cors)</summary> ### [`v9.0.1`](https://togithub.com/fastify/fastify-cors/releases/tag/v9.0.1) [Compare Source](https://togithub.com/fastify/fastify-cors/compare/v9.0.0...v9.0.1) #### What's Changed - vary origin on delegated options by [@​laat](https://togithub.com/laat) in [fastify/fastify-cors#292 #### New Contributors - [@​laat](https://togithub.com/laat) made their first contribution in [fastify/fastify-cors#292 **Full Changelog**: fastify/fastify-cors@v9.0.0...v9.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the options used are delegated to a function, then the origin could be dynamic and should add
vary: originheader.The symbol usage feels a bit hacky, but the test changes should be ok.
fixes #291
Checklist
npm run testand the Code of conduct