Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are Expander's fields private? #113

Open
mindreader opened this issue Aug 15, 2023 · 1 comment
Open

Why are Expander's fields private? #113

mindreader opened this issue Aug 15, 2023 · 1 comment

Comments

@mindreader
Copy link

I want to use a slightly different expansion method, the default, but with allow_undelimited_name: false, but I can't see a way to do it with the public api available.

@keith-hall
Copy link
Contributor

I would guess that the idea is to only expose things we know will be used, because once something is public we need to be more careful when making changes etc. and support various previously unthought of interactions.

I'd say open a PR, and then we can get more of an idea of how much maintenance burden it could add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants