fix(smtp-notification-test): missing allowSelfSigned option in test function #1461
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauthier-th
requested changes
Mar 12, 2025
fallenbagel
approved these changes
Mar 13, 2025
gauthier-th
approved these changes
Mar 13, 2025
brotaxt
pushed a commit
to brotaxt/jellyseerr
that referenced
this pull request
Mar 16, 2025
…unction (fallenbagel#1461) * fix(smtp-notification-test): missing allowSelfSigned option in test function * fix: indent error
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
ishanjain28
pushed a commit
to ishanjain28/jellyseerr
that referenced
this pull request
Mar 20, 2025
…unction (fallenbagel#1461) * fix(smtp-notification-test): missing allowSelfSigned option in test function * fix: indent error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SMTP test functionality was not working when using self-signed certificates due to the missing
allowSelfSignedoption in the request body.This commit ensures that
allowSelfSigned: values.allowSelfSignedis properly included, allowing self-signed certificates when enabled in the settings.To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed