Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 2.7 #2885

Closed
stefannibrasil opened this issue Jan 10, 2024 · 8 comments
Closed

Drop support for Ruby 2.7 #2885

stefannibrasil opened this issue Jan 10, 2024 · 8 comments

Comments

@stefannibrasil
Copy link
Contributor

stefannibrasil commented Jan 10, 2024

We're still supporting Ruby 2.7 but this version is not maintained anymore. To ensure faker is up to date with Ruby, we want to drop EOL versions and be fully running on the latest.

Here is a PR example from when we last dropped support for Ruby EOL versions: #2538. We also need to update any mention to Ruby 2.7 and replace it with 3.0.

The minimum Ruby version is going to be 3.0.

This is a great first-time contributor issue. If you're a contributor already, please leave it for someone looking for first-time issues 🤗

@koic
Copy link
Member

koic commented Jan 10, 2024

The latest stable version of Rails (7.1) supports Ruby 2.7.
https://rubygems.org/gems/rails/versions/7.1.2

IMHO, Since Rails has a significant market presence, I think it is still valuable for the library to support Ruby 2.7, independent of its EOL.

@stefannibrasil
Copy link
Contributor Author

Fair enough! FYI, Rails is already in preparation for dropping Ruby 2.7 soon rails/rails#50491

I understand Rails is a good reference but I'd like to keep our Ruby support up to Ruby's EOL calendar. No strong opinions, though.

@koic
Copy link
Member

koic commented Jan 10, 2024

Yes. After Rails 8 is released, the minimum required version of Ruby will change. However, it should be noted that Rails 7.1 will not become EOL immediately.

@stefannibrasil
Copy link
Contributor Author

Sounds good, thanks! I guess I was too excited to start the year with this change but it can wait 😊

What do you think of having a guideline for this in the Maintaining doc? https://github.com/faker-ruby/faker/blob/main/MAINTAINING.md

@koic
Copy link
Member

koic commented Jan 10, 2024

Although it might be beneficial to mention this in the doc, I don't have a strong preference regarding it. Your discretion in this matter would be appreciated. Thank you very much for taking it into consideration!

stefannibrasil added a commit that referenced this issue Jan 12, 2024
Inspired by the discussion here #2885, I asked some friends about it and
I want to propose this guideline: support one EOL version at a time.
@stefannibrasil
Copy link
Contributor Author

Thank you, Koic for the discussion! I proposed a guideline here for the future here #2890

Gonna close this one for now and reopen when at least Ruby 3.0 is EOL.

stefannibrasil added a commit that referenced this issue Jan 18, 2024
Inspired by the discussion here #2885, I asked some friends about it and
I want to propose this guideline: support one EOL version at a time.
@koic
Copy link
Member

koic commented Jan 27, 2024

For reference, RuboCop has changed its maintenance policy and decided to support Ruby 2.7 for an extended period, regardless of Ruby 3.0's EOL. For more details, please see the following:
https://docs.rubocop.org/rubocop/1.60/compatibility.html#support-matrix

@stefannibrasil
Copy link
Contributor Author

That's really nice for RuboCop! As faker does not have many active maintainers, doing that here would be too much for the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants