Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh-CN translations for Bank names #2840

Merged
merged 2 commits into from Oct 28, 2023
Merged

Conversation

guxiaobai
Copy link
Contributor

@guxiaobai guxiaobai commented Oct 16, 2023

Motivation / Background

This Pull Request has been created because [REPLACE ME]

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator:

  • Open an issue first for discussion before you write any code.
  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Documentation guidelines.

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Please change the syntax to use dashes instead of an array, take a look at this doc:
https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#yaml-files

zh-CN:
faker:
bank:
name: ['工商银行', '交通银行', '招商银行', '民生银行', '浦发银行', '兴业银行', '光大银行', '广发银行', '平安银行', '建设银行', '邮政储蓄银行']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we prefer to use the dash syntax for lists of elements, see documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I've repaired it

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you!

@thdaraujo thdaraujo changed the title add china bank name Add zh-CN translations for Bank names Oct 28, 2023
@thdaraujo thdaraujo merged commit ce634e1 into faker-ruby:main Oct 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants